Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N/A] SVG Support Removal #155

Merged
merged 3 commits into from
Oct 16, 2024
Merged

[N/A] SVG Support Removal #155

merged 3 commits into from
Oct 16, 2024

Conversation

bd-viget
Copy link
Contributor

@bd-viget bd-viget commented Oct 16, 2024

Summary

This PR eradicates SVG Support and replaces it with Safe SVG. This was supposed to be in the last PR, however, something weird happened with the composer file (maybe a bad merge), and it still remained.

Issues

I just realized some of this work is duplicated in this PR, but this solution is a bit more robust, and cleans up some WP Site Starter specific GitHub files.

Testing Instructions

  1. On a fresh install, the Safe SVG plugin should be included, not SVG Support.

@bd-viget bd-viget self-assigned this Oct 16, 2024
@bd-viget bd-viget requested a review from nevinsm October 16, 2024 13:12
@bd-viget
Copy link
Contributor Author

@nevinsm When you get a moment, I want to draw your attention to the changes in this file.

I am removing the GitHub deploy.yaml file - If I'm not mistaken, this is specific to our deployments to wpstarter.vigetx.com and kit.wpstarter.vigetx.com, and we don't want it on new projects. Just want to make sure it makes sense to remove it, or do you think it's beneficial to keep in as a skeleton.

Copy link
Contributor

@nathan-schmidt-viget nathan-schmidt-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nevinsm
Copy link
Contributor

nevinsm commented Oct 16, 2024

@bd-viget That looks fine to me. If anyone wants to use it they can always just go grab it from this repo.

@bd-viget bd-viget merged commit c615cd5 into main Oct 16, 2024
@bd-viget bd-viget deleted the bd/svg-support-removal branch October 16, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants