Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[N/A] Disable Composer Script if not in Dev Mode #156

Merged
merged 2 commits into from
Oct 16, 2024
Merged

[N/A] Disable Composer Script if not in Dev Mode #156

merged 2 commits into from
Oct 16, 2024

Conversation

bd-viget
Copy link
Contributor

Summary

This prevents the composer scripts from running unless in Dev Mode.

Issues

  • N/A

Testing Instructions

  1. Run a deployment
  2. Hopefully everything deploys.

@bd-viget bd-viget self-assigned this Oct 16, 2024
nathan-schmidt-viget
nathan-schmidt-viget approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@nathan-schmidt-viget nathan-schmidt-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me, but will let Nevin give the final word.

@bd-viget bd-viget merged commit 4e4e59d into main Oct 16, 2024
@bd-viget bd-viget deleted the bd/fix-composer-deployment branch October 16, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevinsm nevinsm nevinsm approved these changes

@nathan-schmidt-viget nathan-schmidt-viget nathan-schmidt-viget approved these changes

Assignees

@bd-viget bd-viget

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bd-viget @nevinsm @nathan-schmidt-viget