Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#150] Fix duplicate editor background #159

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

bd-viget
Copy link
Contributor

Summary

This PR fixes the duplicate background issue when viewing the block in the editor.

Issues

Testing Instructions

  1. Create a CTA block
  2. Add a background image
  3. Make sure it's only on one element

@bd-viget bd-viget self-assigned this Oct 17, 2024
Copy link
Contributor

@nathan-schmidt-viget nathan-schmidt-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bd-viget bd-viget force-pushed the bd/150-cta-background-issue branch from 9665cd5 to 356aed8 Compare October 18, 2024 18:41
@bd-viget
Copy link
Contributor Author

@nathan-schmidt-viget I ran into a few issues with the base buttons and hover colors, so I threw a few fixes into this PR to address it.

@bd-viget bd-viget merged commit 6d56877 into main Oct 18, 2024
@bd-viget bd-viget deleted the bd/150-cta-background-issue branch October 18, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants