Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N/A] Various Cleanup and Feedback from PHCC #161

Merged
merged 19 commits into from
Nov 13, 2024
Merged

Conversation

bd-viget
Copy link
Contributor

@bd-viget bd-viget commented Oct 18, 2024

Summary

This PR incorporates some of the items found during development of PHCC, as well as a few other things addressed in prep for PHCC.

Changelog

  • Cleanup Navigation Container component, moved styles into CSS file.
  • Remove "Dark" label from colors prefixed with dark-
  • Added default logo
  • Added Icon Only Button Style
  • Added more block support in the Navigation Container component (Site Logo, Buttons, Search, Spacer, and Separator)
  • Added new filter to unregister core block styles: acfbt_unregister_block_styles
  • PostInstall Enhancements
  • Improvements to the Color Palette feature
  • Moved some core functionality from the theme to the MU Plugin
  • Block Icon Support for the Read More Block
  • Disable the Template Part wrapper div when using Template parts
  • Implemented ACF Blocks Toolkit API function acfbt() to access functionality from ACF BT.

@bd-viget bd-viget self-assigned this Oct 18, 2024
@bd-viget bd-viget changed the title [N/A] Navigation Container Cleanup [N/A] Various Cleanup and Feedback from PHCC Nov 12, 2024
@bd-viget bd-viget marked this pull request as ready for review November 12, 2024 20:48
@bd-viget bd-viget requested a review from ten1seven November 13, 2024 19:00
Copy link
Contributor

@nathan-schmidt-viget nathan-schmidt-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
My only thought is how are we changing the buttons/text when they are on a dark background? Are we adding a class dark to the block?

@bd-viget
Copy link
Contributor Author

Yes, we are still adding the dark- prefix to the slug of the color, however, checking for [class*="has-dark-"] became problematic when an element used a dark text color, adding the class has-dark-black-color, which would produce undesired results. So now we're using css.js to dynamically modify the inner elements' text color when nested in a has-dark-*-background-color element. There is room for improvement with this approach, but will provide more consistent/expected results.

@bd-viget bd-viget merged commit 423cb4a into main Nov 13, 2024
@bd-viget bd-viget deleted the bd/block-cleanup branch November 13, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants