Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAC] Feedback #163

Merged
merged 9 commits into from
Jan 3, 2025
Merged

[SAC] Feedback #163

merged 9 commits into from
Jan 3, 2025

Conversation

bd-viget
Copy link
Contributor

Summary

These changes were inspired by the work performed on SAC. Details below

Updates

  • New default jsx template; Blocks that require no customization do not need render files.
  • Added plain (or is-style-plain) Core button style
  • New ACF BT Features: Media Position & Block Visibility (Responsive Controls)
  • Adjustments to the default Mobile Menu Styles with breakpoint usage
  • Modified default Page template to no longer show title/featured image.
  • Add Block Icon Support for Pagination Previous/Next.
  • Removed some unused patterns/categories
  • Moved Tailwind Button styles into Core/Buttons file.
  • Moved Eyebrow block class into main blocks.php file.

Testing Instructions

Review/test the enhancements outlined above.

Screenshots

Screenshot 2024-12-23 at 12 28 44 PM

Copy link
Contributor

@nathan-schmidt-viget nathan-schmidt-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some really nice updates!

"className":"is-style-eyebrow",
"placeholder":"test Text"
"className": "is-style-eyebrow",
"placeholder": "Eyebrow Text"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

// If you update the names or add more fonts you will need to update the file in theme-json/settings/typography.js
// Fonts are handles WP's font loader.
'sans': "Roboto Condensed, sans-serif",
'sans': 'var(--wp--preset--font-family--body)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicccccce!

@bd-viget bd-viget merged commit 90f3795 into main Jan 3, 2025
@bd-viget bd-viget deleted the bd/sac-feedback branch January 3, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants