-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SAC] Feedback #163
[SAC] Feedback #163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some really nice updates!
"className":"is-style-eyebrow", | ||
"placeholder":"test Text" | ||
"className": "is-style-eyebrow", | ||
"placeholder": "Eyebrow Text" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
// If you update the names or add more fonts you will need to update the file in theme-json/settings/typography.js | ||
// Fonts are handles WP's font loader. | ||
'sans': "Roboto Condensed, sans-serif", | ||
'sans': 'var(--wp--preset--font-family--body)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicccccce!
Summary
These changes were inspired by the work performed on SAC. Details below
Updates
jsx
template; Blocks that require no customization do not need render files.plain
(oris-style-plain
) Core button styleblocks.php
file.Testing Instructions
Review/test the enhancements outlined above.
Screenshots