-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#69] Page Header Component #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this fulfills what the Figma images show but reading the ticket, I think there's a mismatch in spec versus images?
I thought so too, but I guess I assumed the Breadcrumbs were the "menu items" and the Company Logo was the image. Also, it's usually a bit strange to specify the links in Breadcrumbs, usually the site map decides that automatically. |
Yea, spec duplication seems to be the case. |
c819001
to
07c1a12
Compare
Ok, when testing this, you may need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
7995fe2
to
699dd67
Compare
Summary
This PR adds the Page Header Component. The basic styles have been added with plain CSS, so it's going to need some of @nathan-schmidt-viget's Tailwind love!
Issues
Testing Instructions
Screenshots