[#67] Header navigation #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-schmidt-viget
force-pushed
the
ns/67-header-style
branch
from
1384bd5 to
a9b88b4
Compare
ten1seven
approved these changes
May 21, 2024
bd-viget
approved these changes
May 22, 2024
wp-content/themes/wp-starter/blocks/navigation-container/block.php
Outdated
Show resolved
Hide resolved
wp-content/themes/wp-starter/blocks/navigation-container/render.php
Outdated
Show resolved
Hide resolved
wp-content/themes/wp-starter/blocks/navigation-container/render.php
Outdated
Show resolved
Hide resolved
wp-content/themes/wp-starter/blocks/navigation-container/render.php
Outdated
Show resolved
Hide resolved
wp-content/themes/wp-starter/blocks/navigation-container/render.twig
Outdated
Show resolved
Hide resolved
nathan-schmidt-viget
force-pushed
the
ns/67-header-style
branch
from
b6bf578 to
f32e645
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This styles the header navigation. Removed the WP default a11y as it was not fully 100% a11y and built my own with AlpineJS. Because we can't access some of the navigation HTML I had to inject the Alpine with JS onto the DOM.
The dark version will just change if we add
darkto the parent div in the parts.The styles are pretty basic allowing us to customize per client.
Issues
Testing Instructions
Screenshots
May-21-2024.08-14-12.mp4