[#78] Making the css build file smaller #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-schmidt-viget
force-pushed
the
ns/78-button-dark-style
branch
from
27fff49 to
f5c4106
Compare
ten1seven
approved these changes
May 22, 2024
bd-viget
approved these changes
May 22, 2024
wp-content/themes/wp-starter/src/styles/custom-blocks/buttons.css
Outdated
Show resolved
Hide resolved
nathan-schmidt-viget
force-pushed
the
ns/78-button-dark-style
branch
from
f5c4106 to
de4371d
Compare
nathan-schmidt-viget
force-pushed
the
ns/78-button-dark-style
branch
from
de4371d to
68c574b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Brian noticed the CSS file could be trimmed down and I noticed the text/buttons were not changing color when a dark background color was set as the background.
button.jsfile.&[class*='has-dark']. This will save us a lot of file size once we start adding more colors to the theme.cssnanoper the TW docs for modification on the production build.All of this saves us 15 kB and will help keep the file small on a project when we add more colors and custom styles.
Issues
Testing Instructions
ddev npm run buildto see the new file size.Screenshots
Before
After