[#91] Adding admin user name to post install #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ten1seven
approved these changes
May 30, 2024
bd-viget
approved these changes
May 30, 2024
| @@ -628,6 +628,7 @@ public static function renderSuccessMessage(): void { | |||
| $success = [ | |||
| 'Congratulations!', | |||
| 'Project has been set up successfully!', | |||
| 'Admin Username: viget', | |||
There was a problem hiding this comment.
Since we're hard-coding the admin username when creating the initial user, it would probably be best to set a constant in PostInstallScript (const DEFAULT_ADMIN_USER = 'viget') and use that variable when creating the user as well as in the success message.
Even one step further might be add a step to the getSiteInfo() method just before collecting the Admin Email to allow the Username to be set during installation (using the new constant as the default).
There was a problem hiding this comment.
Thanks for the links in the code! Made it easy to update and allow the username to be set during install!
nathan-schmidt-viget
force-pushed
the
ns/91-install-username
branch
from
6319fbb to
ea6b613
Compare
nathan-schmidt-viget
force-pushed
the
ns/91-install-username
branch
from
b87fbea to
9c4eefa
Compare
bd-viget
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At the end of the composer install it is not very clear what the username is for the admin. So that is now added.
Issues
Testing Instructions
Screenshots
NA