Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#95] Fixing button outline border bug #96

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

nathan-schmidt-viget
Copy link
Contributor

Summary

This fixes a few bugs with the button.

  • Option to change the bg color and text color.
  • The outline variant defaults to a transparent bg.
  • When you set the text color it should set the border color.

Issues

Testing Instructions

  1. Add a block that has a button or just add the button block.
  2. Make sure you can change the bg/text color.
  3. The Outline variant defaults to a transparent bg.
  4. When you set the text color for the outline variant it sets the border color.

Screenshots

Can set a bg/text color overriding the default for both variants.
Screenshot 2024-05-29 at 12 28 30 PM

When you set the text color it should set the border color.
Screenshot 2024-05-29 at 12 30 48 PM

Copy link
Contributor

@bd-viget bd-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating this!

@nathan-schmidt-viget nathan-schmidt-viget merged commit 2288d30 into main May 30, 2024
@nathan-schmidt-viget nathan-schmidt-viget deleted the ns/91-btn-color branch May 30, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants