[#90] Fixing placeholder bug, adding phpcs file for bin #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
So I noticed that when you create a new site it does not do a search/replace on the twig files. Once I found the line of code I saved it and noticed that the composer files don't have a default PHP cs (so mine defaulted to WP and changed everything). I added a
.phpcsfile based on PSR12 which is pretty much what Craft follows so we have a base php format for the files in the bin.Issues
Testing Instructions
mainand runcomposer create-project --prefer-dist --stability=dev viget/wordpress-site-starter:dev-mainScreenshots
NA