[#93] Moving the delating to after DB install #98
Conversation
There was a problem hiding this comment.
Nice catch! This is definitely on me! I believe I changed the code from deleting using PHP (unlink/rmdir all files in the path) to using wp cli, which requires a WP install to do.
That being said, we should probably check for a valid WordPress installation (wp core is-installed) before executing deleteCoreThemes() and deleteCorePlugins() since you can choose to skip the database import step, otherwise you could get the same error if there is no database. - Nothing to worry about ATM, but just making a note.
|
@bd-viget I added the check |
nathan-schmidt-viget
force-pushed
the
ns/93-default-theme-plugin
branch
from
0496e43 to
4e5dcf9
Compare
| // Remove the core Twenty-X themes. | ||
| self::deleteCoreThemes(); | ||
|
|
||
| // Remove Hello Dolly. | ||
| self::deleteCorePlugins(); |
There was a problem hiding this comment.
| // Remove the core Twenty-X themes. | |
| self::deleteCoreThemes(); | |
| // Remove Hello Dolly. | |
| self::deleteCorePlugins(); | |
| if ( self::isWordPressInstalled() ) { | |
| // Remove the core Twenty-X themes. | |
| self::deleteCoreThemes(); | |
| // Remove Hello Dolly. | |
| self::deleteCorePlugins(); | |
| } |
I was thinking something more along the lines of this. If the user chose to not load a database, there's no reason to report an error, and it only adds the condition in 1 place, rather than 2.
Summary
The composer install does not delete the themes or the plugins. These two may to happen after the DB. So trying to run both of these after the DB is set up.
@bd-viget not sure about this fix, but it may be the problem. You may have a better idea on what is going on and why the files are not getting removed.
Issues
Testing Instructions
mainand we run the install.Screenshots