Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WSL] 'volt rm tyru/caw.vim' always fail at the first run #1

Closed
tyru opened this issue Sep 23, 2017 · 6 comments
Closed

[WSL] 'volt rm tyru/caw.vim' always fail at the first run #1

tyru opened this issue Sep 23, 2017 · 6 comments
Labels

Comments

@tyru
Copy link
Member

tyru commented Sep 23, 2017

  • NOTE: This is WSL (Windows Subsystem Linux) specific error.
  • NOTE: I must apply the patch manually to Go source code and make precompile before creating GitHub release binaries.

Because of too many files?
I must run volt rm tyru/caw.vim twice to uninstall...

$ ~/volt/bin/volt rm tyru/caw.vim
[INFO] Removing /home/tyru/volt/repos/github.com/tyru/caw.vim ...
Failed to remove repository: remove /home/tyru/volt/repos/github.com/tyru/caw.vim/after/ftplugin: directory not empty

Link: https://github.com/tyru/caw.vim

@tyru tyru changed the title 'volt rm tyru/caw.vim' always fail 'volt rm tyru/caw.vim' always fail at the first run Sep 23, 2017
@tyru
Copy link
Member Author

tyru commented Sep 24, 2017

(Maybe) Related: golang/go#20841

My environment is WSL.

@tyru
Copy link
Member Author

tyru commented Sep 24, 2017

I confirmed the above patch fixed this issue.

Steps

  1. cd ~/.gvm/gos/go1.9
  2. curl -L -o 91e0f54.diff.zip https://go-review.googlesource.com/changes/62970/revisions/2/patch?zip
  3. unzip 91e0f54.diff.zip
  4. patch -p1 <91e0f54.diff
  5. cd $GOPATH/src/github.com/vim-volt/volt
  6. make precompile

Then bin/volt rm tyru/caw.vim does not raise an error anymore!

Environment

  • go version go1.9 linux/amd64
  • WSL
    • OS name: Microsoft Windows 10 Pro (from systeminfo command)
    • OS version: 10.0.15063 N/A Build 15063 (from systeminfo command)
    • Ubuntu 16.04.3 LTS
$ lsb_release -a
lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.3 LTS
Release:        16.04
Codename:       xenial

@tyru tyru closed this as completed Sep 24, 2017
tyru added a commit that referenced this issue Sep 24, 2017
Noted about build environment (#1).
@tyru
Copy link
Member Author

tyru commented Dec 11, 2017

This seems to occur again in go1.10beta1.
I've also tried go1.9.2, but it works well.

  • (fail) go1.9
  • (success) go1.9.1
  • (success) go1.9.2
  • (fail) go1.10beta1

@tyru
Copy link
Member Author

tyru commented Dec 11, 2017

golang/go#20841 (comment)

This seems to occur again in go1.10beta1.

Sorry, deleted my comment because it was totally wrong.
After checking the source code, it appears this patch has not been applied yet to go1.9.1, go1.9.2, go1.10beta1.

@tyru tyru changed the title 'volt rm tyru/caw.vim' always fail at the first run [WSL] 'volt rm tyru/caw.vim' always fail at the first run Dec 11, 2017
@tyru
Copy link
Member Author

tyru commented Dec 11, 2017

Created modified patch for go1.10beta1.
https://gist.github.com/tyru/b6c8cfa8b4072ca0ee791065c669d79a

@tyru
Copy link
Member Author

tyru commented Sep 18, 2018

golang/go#20841 (comment)

OK, that was fast. We believe this has been fixed in WSL in the recently released Windows 10 Fall Creators Update ("RS3", build 16299). Please let us know if you're able to reproduce this after updating to the latest Windows release.

@tyru tyru closed this as completed Sep 18, 2018
@tyru tyru mentioned this issue May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant