Add download links to the download page #118

ap4y · 2020-10-05T04:19:05Z

I have spent some time on adding download links to the "Download" page and I'm curious what everyone think about this version:

x86	i686	arm	nojs

Notable changes:

Pushed various archs to the tabs, I think users usually interested in the specific platform
Added download links for all archs and flavors for live images and tarballs
Tweaked details for each arch and pushed it to the side

The downside of these changes is that build date has to be updated in the config after each new build, I think it happens rarely so hopefully won't create too much load. If someone will notice that something is off, I'm happy to tweak it.

ericonr · 2020-10-05T04:54:07Z

Hi! I really like these changes! I still have some thoughts on the text parts, but also a style consideration. How does this page look on a phone?

ap4y · 2020-10-05T04:57:21Z

Thanks @ericonr. Mobile previews:

ahesford · 2020-10-05T11:22:01Z

I think this looks very good, but have a couple of suggestions that I think will improve the viewing experience:

Don't split the x86_64* tabs if you aren't also splitting the ARM tabs by C library. Put the glibc and musl links side-by-side in one list.
In the ARM tab, break the "live image" and rootfs options onto two lines, so you have something like "Live image, rootfs \n Live image (musl), rootfs (musl)".

EDIT: Apparently the Markdown parser ate my br tag, replaced with '\n' instead.

_platforms/arm.md

_includes/download_pc.html

ericonr · 2020-10-05T15:28:06Z

_platforms/arm.md

+- [USB Armory](https://wiki.voidlinux.org/USB_Armory)
+{% endcapture %}
+
+{% include download_arm.html content=download_details %}


I think we are losing some of the information here, such as the link to the page about RPis in the handbook. I also wouldn't like to lose the device information for each board (like ARMv7, hard float we currently have). Not sure if it could fit inside this, though.

I have added arch back without hard float since all devices are hard float. I have removed a link to the RPI docs because the copy before it points to the related doc page (General and platform specific instructions for these images are available in the documentation.), I think this should be enough in this case. WDYT?

Sounds great.

Chocimier

I like appearance. Could you set up live demo to play with (eg. github pages), rather than screenshots?

_layouts/download.html

ap4y · 2020-10-06T01:34:57Z

Thanks for the reviews. I have pushed updates based on the feedback and updated screenshots in the first message. The only thing I haven't done is splitting "live images" and "rootfs" into separate lines, I tried different variants but felt like the links look the best inline. I have re-grouped links and added glibc and musl badges to make the separation a bit more clear, please let me know what you think about this :)

@Chocimier you can test these changes locally, just pull the branch and then bundle install followed by bundle exec jekyll s, preview should be up on port 4000 by default.

ericonr · 2020-11-23T19:45:38Z

I will try to set something up on GitHub Pages so we can discuss this more easily. I really want to get this design into the download pages.

ap4y · 2020-11-24T02:49:15Z

I have deployed to GH pages from my branch. You can preview it here: https://ap4y.github.io/void-linux.github.io/download/

ericonr · 2020-11-24T03:10:40Z

What do you think about taking the opportunity to increase the font size a bit? I always felt it was quite small

ap4y · 2020-11-25T01:56:51Z

@ericonr are you referring to site-wide font updates or on the download page specifically? if it's the former then perhaps it will be better to handle this in a separate PR along with other potential typography improvements? I personally think that light fonts are not a great option for the content heavy websites, maybe worth trying to switch to a regular font weight as quick fix? 14px font size that is being used is not small but in combination with certain fonts it might be harder to read.

ericonr · 2020-11-25T02:03:07Z

For some reason the fonts only bother me on the download page, even though it seems to be the same style in the main page... I'm not sure why that is, but perhaps increasing it site wide wouldn't be too bad.

paper42 · 2020-11-25T08:55:35Z

The font size is set in bootstrap.css, a best practice is not forcing users to a specific font size, so we should remove it.

Duncaen · 2020-11-25T12:36:48Z

What about putting the text left and the download links right? This would put headlines on the left without JS enabled and would have the headline first in mobile.
The tab bar could have links with ids that scroll to the right architecture headline without JS.

ap4y · 2020-11-26T06:01:14Z

Updated per @Duncaen's suggestions:

Swapped panels on each tab
Added tab links and header anchors

Updated version is up on the same link.

the-maldridge

Several nits and I'd like to split up the page that's currently called 'arm' into 2 pages with one being a page on rootfs's and one specifically talking about SBCs.

_config.yml

_includes/download_details_pc.md

assets/js/misc.js

the-maldridge · 2020-11-26T08:19:16Z

_platforms/arm.md

@@ -0,0 +1,37 @@
+---


I'm not entirely happy calling this arm when we have both specific dialects as well as platform filesystems. I'd almost rather split this section into two and have one that just talks about that you can get arbitrary rootfs tarballs, and another page that talks about SBCs and links to the relevant pages in the documentation.

This would also be nice as I'd like to add a tab for the various cloud platforms that Void supports.

I have split ARM into 2 sections and sketched content for both, would appreciate a review on those.

re cloud images: I only see GCP tarball at https://alpha.de.repo.voidlinux.org/live/current/ , what other platforms we want to show on the downloads page?

Both GCP and DigitalOcean are known to work and are some semblance of supported (Void itself has infrastructure running on DigitalOcean). For both though the images are not distributed by default, so just having a place to link back to the docs on how to generate the image on demand would be great.

the-maldridge · 2020-11-27T03:15:40Z

Looks pretty good. All my major concerns have been addressed. @void-linux/webmasters for final approval. The cloud page can be added with just a pointer to mklive for now, and more instructions can be added later.

ericonr

Ok, I think I went through all the issues I noticed.

Man, I really like this page, thanks a lot!

_includes/download_details_pc.md

_platforms/arm.md

ericonr · 2020-11-27T03:38:14Z

_platforms/arm.md

+- [USB Armory](https://wiki.voidlinux.org/USB_Armory)
+{% endcapture %}
+
+{% include download_arm.html content=download_details %}


Sounds great.

_platforms/sbc.md

_includes/download_pc.html

the-maldridge · 2020-11-27T05:00:43Z

@ericonr's feedback is good, once that's complete this will be merged.

ap4y · 2020-11-30T02:02:19Z

Thanks for the feedback @ericonr, PR was updated with the fixes.

the-maldridge · 2020-12-02T05:24:07Z

@ap4y please squash your changes to 1 commit, once you have done this ping me for merge.

ap4y · 2020-12-02T05:36:20Z

@the-maldridge done

ap4y force-pushed the download-redesign branch from f26ef2f to dcbf996 Compare October 5, 2020 08:00

ericonr reviewed Oct 5, 2020

View reviewed changes

Chocimier reviewed Oct 5, 2020

View reviewed changes

_layouts/download.html Outdated Show resolved Hide resolved

ap4y changed the title ~~Add downloads links to the download page~~ Add download links to the download page Oct 5, 2020

ap4y force-pushed the download-redesign branch from dcbf996 to f656ade Compare October 6, 2020 01:24

the-maldridge requested changes Nov 26, 2020

View reviewed changes

ericonr suggested changes Nov 27, 2020

View reviewed changes

Add downloads links to the download page

0358c5f

ap4y force-pushed the download-redesign branch from 26c71ad to 0358c5f Compare December 2, 2020 05:35

the-maldridge merged commit b539f34 into void-linux:master Dec 2, 2020

ap4y mentioned this pull request Dec 8, 2020

Use system fonts instead of Ubuntu #123

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add download links to the download page #118

Add download links to the download page #118

ap4y commented Oct 5, 2020 •

edited

Loading

ericonr commented Oct 5, 2020

ap4y commented Oct 5, 2020 •

edited

Loading

ahesford commented Oct 5, 2020 •

edited

Loading

ericonr Oct 5, 2020

ap4y Oct 6, 2020

ericonr Nov 27, 2020

Chocimier left a comment

ap4y commented Oct 6, 2020

ericonr commented Nov 23, 2020

ap4y commented Nov 24, 2020

ericonr commented Nov 24, 2020

ap4y commented Nov 25, 2020

ericonr commented Nov 25, 2020

paper42 commented Nov 25, 2020

Duncaen commented Nov 25, 2020 •

edited

Loading

ap4y commented Nov 26, 2020

the-maldridge left a comment

the-maldridge Nov 26, 2020

ap4y Nov 27, 2020

the-maldridge Nov 27, 2020

the-maldridge commented Nov 27, 2020

ericonr left a comment

ericonr Nov 27, 2020

the-maldridge commented Nov 27, 2020

ap4y commented Nov 30, 2020

the-maldridge commented Dec 2, 2020

ap4y commented Dec 2, 2020

Add download links to the download page #118

Add download links to the download page #118

Conversation

ap4y commented Oct 5, 2020 • edited Loading

ericonr commented Oct 5, 2020

ap4y commented Oct 5, 2020 • edited Loading

ahesford commented Oct 5, 2020 • edited Loading

ericonr Oct 5, 2020

Choose a reason for hiding this comment

ap4y Oct 6, 2020

Choose a reason for hiding this comment

ericonr Nov 27, 2020

Choose a reason for hiding this comment

Chocimier left a comment

Choose a reason for hiding this comment

ap4y commented Oct 6, 2020

ericonr commented Nov 23, 2020

ap4y commented Nov 24, 2020

ericonr commented Nov 24, 2020

ap4y commented Nov 25, 2020

ericonr commented Nov 25, 2020

paper42 commented Nov 25, 2020

Duncaen commented Nov 25, 2020 • edited Loading

ap4y commented Nov 26, 2020

the-maldridge left a comment

Choose a reason for hiding this comment

the-maldridge Nov 26, 2020

Choose a reason for hiding this comment

ap4y Nov 27, 2020

Choose a reason for hiding this comment

the-maldridge Nov 27, 2020

Choose a reason for hiding this comment

the-maldridge commented Nov 27, 2020

ericonr left a comment

Choose a reason for hiding this comment

ericonr Nov 27, 2020

Choose a reason for hiding this comment

the-maldridge commented Nov 27, 2020

ap4y commented Nov 30, 2020

the-maldridge commented Dec 2, 2020

ap4y commented Dec 2, 2020

ap4y commented Oct 5, 2020 •

edited

Loading

ap4y commented Oct 5, 2020 •

edited

Loading

ahesford commented Oct 5, 2020 •

edited

Loading

Duncaen commented Nov 25, 2020 •

edited

Loading