Drop EoL Puppet 6 #672
Merged
Drop EoL Puppet 6 #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
approved these changes
May 24, 2023
|
rspec locally is okay 2.7.6 but not 2.7.8 - concurrent-ruby gem usually. @smortex merge ? Its no worse than what is merged already. |
smortex
approved these changes
May 24, 2023
|
Another step in the right direction , i've disable some particiular cops but at least some of them are going to require some reworking so doing after makes sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Drop EoL Puppet 6
This Pull Request (PR) fixes the following issues
Fixes #670
Fixes #671
Fixes #633