Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR #392 + added rundeck_commitid fact #402

Merged
merged 6 commits into from
Oct 3, 2018

Conversation

smasa90
Copy link
Contributor

@smasa90 smasa90 commented Oct 2, 2018

Pull Request (PR) description

This PR fixes rebase needed of PR #392
Added another fact : rundeck_commitid

This Pull Request (PR) fixes the following issues

This PR fixes rebase needed of PR #392
Added another fact : rundeck_commitid

@bastelfreak
Copy link
Member

Hi @smasa90. Can you please take a look at the failing travis job and add a unit test for this?

@smasa90
Copy link
Contributor Author

smasa90 commented Oct 2, 2018

@bastelfreak Sorry, forgot to push :/
Added unit test for these facts at same time.
Don't have idea why my test file don't cover all the tested file, would you mind just to throw an eye on it ?

@bastelfreak bastelfreak added bug Something isn't working and removed tests-fail needs-tests labels Oct 3, 2018
@bastelfreak bastelfreak merged commit 286c628 into voxpupuli:master Oct 3, 2018
@smasa90 smasa90 deleted the fix/facter-version branch October 3, 2018 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants