Add config support for Hashicorp Vault plugin #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Oct 25, 2019
bastelfreak
reviewed
Oct 25, 2019
bastelfreak
reviewed
Oct 25, 2019
manifests/params.pp
Outdated
| @@ -316,6 +316,13 @@ | |||
| $file_keystorage_keys = { } | |||
| $file_keystorage_dir = "${framework_config['framework.var.dir']}/storage" | |||
|
|
|||
| $vault_keystorage_prefix = 'rundeck' | |||
| $vault_keystorage_url = 'https://vault.example.com' | |||
There was a problem hiding this comment.
please default to undef here
bastelfreak
reviewed
Oct 25, 2019
manifests/params.pp
Outdated
| @@ -316,6 +316,13 @@ | |||
| $file_keystorage_keys = { } | |||
| $file_keystorage_dir = "${framework_config['framework.var.dir']}/storage" | |||
|
|
|||
| $vault_keystorage_prefix = 'rundeck' | |||
| $vault_keystorage_url = 'https://vault.example.com' | |||
| $vault_keystorage_approle_approleid = '111111-222222-333333-44444-55555' | |||
There was a problem hiding this comment.
please default to undef here
bastelfreak
reviewed
Oct 25, 2019
manifests/params.pp
Outdated
| $vault_keystorage_prefix = 'rundeck' | ||
| $vault_keystorage_url = 'https://vault.example.com' | ||
| $vault_keystorage_approle_approleid = '111111-222222-333333-44444-55555' | ||
| $vault_keystorage_approle_secretid = 'aaaaaa-bbbbbbb-ccccccc-dddddd-eeeeee' |
There was a problem hiding this comment.
please default to undef here
bastelfreak
reviewed
Oct 25, 2019
bastelfreak
added
enhancement
|
Hi @linuxmail, thanks for the PR! Can you please take a look at the inline comments I did and also check the used email address in the commits? It isn't associated with your github account. |
…me minor lint fixes
|
Hi, I've added the fixes and looking later for other kind of stuff to do. Hopefully the mail address is also set on the Git repo :-) |
|
I had to set the Vault entries to Optional, otherwise Travis wasn't happy ("..expected String, got undef..." |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR adds support for the the Vault plugin, which can be used as key storage provider.
This Pull Request (PR) fixes the following issues
Fixes: #428