Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rundeck cli and project management #527

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Conversation

Joris29
Copy link
Contributor

@Joris29 Joris29 commented Jan 11, 2024

Pull Request (PR) description

This introduces the rundeck cli as a seperate class and als add a define to create and manage projects

Fixes #449
Fixes #181
Fixes #67

@Joris29
Copy link
Contributor Author

Joris29 commented Jan 11, 2024

@kenyon Hello it's been a while but i wanted to propose this first draft of the changes i added.
If you have questions or proposals feel free to add them.

Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new code looks fine, but looks like we need to get the tests passing.

@Joris29
Copy link
Contributor Author

Joris29 commented Jan 15, 2024

@kenyon Added unit tests and improved some old test also changed the cli class itself a bit but still having issues with ubuntu repo gpg check

@Joris29 Joris29 closed this Jan 16, 2024
@Joris29 Joris29 reopened this Jan 16, 2024
@Joris29 Joris29 force-pushed the rd_cli branch 3 times, most recently from 7d9ffea to 6d8275e Compare January 16, 2024 08:22
@Joris29 Joris29 force-pushed the rd_cli branch 11 times, most recently from b9fb19d to c806367 Compare January 25, 2024 07:11
@Joris29 Joris29 force-pushed the rd_cli branch 5 times, most recently from ad54ff1 to c48b49e Compare January 25, 2024 13:16
@Joris29 Joris29 marked this pull request as ready for review January 25, 2024 14:39
@Joris29
Copy link
Contributor Author

Joris29 commented Jan 25, 2024

@kenyon I Updated some things and had to remove CentOS 7 from unit tests as jq is not available by default.
Updated refs and readme i also created clean separate commits so those can added as is i think.
This only supports project config itself not project resources (yet). I will this i a follow up PR but i don't want to make it to big.

Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found one typo, otherwise looks good to me

@Joris29
Copy link
Contributor Author

Joris29 commented Jan 26, 2024

Fixed the typo

@kenyon kenyon merged commit 023c6b8 into voxpupuli:master Jan 26, 2024
@kenyon kenyon added the enhancement New feature or request label Jan 26, 2024
@Joris29 Joris29 deleted the rd_cli branch February 9, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants