Skip to content

<Select />でnumber型を扱えるようにする #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2020

Conversation

youchann
Copy link
Contributor

@youchann youchann commented Oct 5, 2020

options: { value: string; label: string; }みたいになっているけれど、valueはnumber型で扱いたいシーンが多い。
なのでよしなに型をオーバーライドできるようにする。

@youchann youchann requested a review from maktak1995 October 5, 2020 03:26
@youchann youchann self-assigned this Oct 5, 2020
Comment on lines +94 to +95
{/* MEMO: Can define Generics */}
<Select<number>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

勝手に推論してくれるけれど、こういった感じでgenericsを定義できる。

Copy link
Contributor

@maktak1995 maktak1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants