Skip to content

Select label design #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 20, 2021
Merged

Select label design #292

merged 17 commits into from
Apr 20, 2021
+535 −201

Conversation

penicillin0
Copy link
Contributor

@penicillin0 penicillin0 commented Apr 9, 2021 •
edited
Loading

やったこと

  • <Select /> のデザインを変更

確認方法

yarn install
yarn storybook

before

image

after

image

@penicillin0 penicillin0 self-assigned this Apr 9, 2021
@netlify
Copy link

netlify bot commented Apr 9, 2021 •
edited
Loading

Deploy preview for ingred-ui ready!

Built with commit 28f24f4

https://deploy-preview-292--ingred-ui.netlify.app

@ryokosuge ryokosuge added the enhancement New feature or request label Apr 16, 2021
@penicillin0 penicillin0 requested a review from noronaoki April 16, 2021 07:34
@noronaoki
Copy link
Contributor

@penicillin0 デザインOKです

@penicillin0 penicillin0 requested a review from ryokosuge April 16, 2021 07:41
ryokosuge
ryokosuge approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@ryokosuge ryokosuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@penicillin0 penicillin0 marked this pull request as ready for review April 20, 2021 05:13
@penicillin0 penicillin0 requested a review from a team as a code owner April 20, 2021 05:13
@penicillin0 penicillin0 removed the request for review from a team April 20, 2021 05:13
@penicillin0 penicillin0 merged commit b8634d4 into master Apr 20, 2021
@penicillin0 penicillin0 deleted the select-label-design branch April 20, 2021 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryokosuge ryokosuge

@noronaoki noronaoki

Assignees

@penicillin0 penicillin0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@penicillin0 @noronaoki @ryokosuge