Skip to content

[Popover]モーダルを開くときに座標を更新するように #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

penicillin0
Copy link
Contributor

@penicillin0 penicillin0 commented Jun 4, 2021

やったこと

  • <Popover>内部のモーダルを開くときに座標を更新するようにした

<Popover>が内部的に使わているコンポーネントについても問題が解決していることを確認しました。

背景など

  • <Popover>を用いているコンポーネントにおいて、参照要素の移動に対して座標の更新がかからず、位置がずれていた
    (参考: https://github.com/voyagegroup/fluct_datastrap/issues/2802)

  • <Popover>内部では参照要素の移動に対しては自動更新に対応していなかったため、手動で更新する必要がある

    The eventListeners modifier adds scroll and resize listeners that update the position of the popper when necessary. These are not exhaustive and don't cover the following cases:

    • When the reference element moves or changes size.
    • When the popper element changes size (i.e. content).

    (https://popper.js.org/docs/v2/modifiers/event-listeners/)

ref

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
@penicillin0 penicillin0 added the bug Something isn't working label Jun 4, 2021
@penicillin0 penicillin0 self-assigned this Jun 4, 2021
@netlify
Copy link

netlify bot commented Jun 4, 2021

✔️ Deploy Preview for ingred-ui ready!

🔨 Explore the source changes: 07fe960

🔍 Inspect the deploy log: https://app.netlify.com/sites/ingred-ui/deploys/60b9c2b0f8fa290008f1cd33

😎 Browse the preview: https://deploy-preview-371--ingred-ui.netlify.app/iframe

@penicillin0 penicillin0 marked this pull request as ready for review June 4, 2021 06:08
@penicillin0 penicillin0 requested a review from a team as a code owner June 4, 2021 06:08
@penicillin0 penicillin0 requested review from youchann and removed request for a team June 4, 2021 06:08
Copy link
Contributor

@youchann youchann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作確認で問題なければLGTMです!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants