Skip to content

@storybook/addon-knobs の設定漏れを修正 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2020

Conversation

youchann
Copy link
Contributor

DropdownButtonのRevertにより@storybook/addon-knobsの設定も消えていた。

※現状のmasterブランチのbuildには問題ない

Verified

This commit was signed with the committer’s verified signature.
amaanq Amaan Qureshi
@youchann youchann self-assigned this May 27, 2020
@youchann
Copy link
Contributor Author

youchann commented May 27, 2020

備考

#31 はまだ未リリースで、当PRの変更とともにリリース予定。

@youchann
Copy link
Contributor Author

@kinokoruumu
こちらお手隙でみていただけると:bow:

合わせて#40 もチラ見していただけると嬉しいです...

@youchann
Copy link
Contributor Author

@maktak1995
ingred-uiに@storybook/addon-knobsというアドオンを導入しているのですが、この前のバグのRevertの影響で設定がデグレしてました。。

今回はその部分を戻したというPRです!!

お手隙でみていただけると:bow:

@youchann
Copy link
Contributor Author

動作確認としては、ブランチ環境
https://deploy-preview-44--ingred-ui.netlify.app/?path=/story/notificationbadge--overview
にアクセスして、フッターにあるknobという部分が問題なく動けばOKです!!

Copy link
Contributor

@maktak1995 maktak1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@youchann youchann merged commit ba6725e into master May 28, 2020
@youchann youchann deleted the tweak-storybook-addons branch May 28, 2020 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants