DropdownButtonバグ対応&disabled対応 #52
Merged
+147
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ついでに |
|
@kinokoruumu |
kinokoruumu
reviewed
Jun 3, 2020
| @@ -16,6 +16,9 @@ export const SplitToggle = styled(Button)` | |||
| border-left: 1px solid ${({ theme }) => theme.palette.primary.deepDark}; | |||
| padding: 0 ${({ theme, size }) => (size === "small" ? 0 : theme.spacing)}px; | |||
| min-width: auto; | |||
| &:disabled { | |||
| border-left: 1px solid ${({ theme }) => theme.palette.divider}; | |||
There was a problem hiding this comment.
nits
色しか変わらないならborder-left-colorでいいかも
There was a problem hiding this comment.
元のスタイルが↓なので、border-left-colorだけだとborderが出なかったです!!
&:disabled {
background-color: ${colors.basic[100]};
color: ${({ theme }) => theme.palette.text.disabled};
border: 0;
}
There was a problem hiding this comment.
あ、そっか！
styled(Button)
ここ見落としてたごめん！
|
active時の色がカンプになかったけどすり合わせ済み？ |
あーこれ僕が勘で当てた色ですね。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onBlurの際もonClickが走るのでfixsplitなボタンなのにトグル押してもonClickが走るのでfix