Skip selector calculation of non-violation results #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @tsmd, how are you? Thank you for your contribution! Can you make this dynamic, which can be passed at the time of installation, through the options? |
|
@ktquez I've changed the options to be dynamic. Can you check again, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It takes a very long time to inspect a huge page with a large number of nodes.
According to the official documentation, one of the reasons it takes so long to process is the selector calculation. It takes time because the calculations are performed not only for the items that failed the test, but also for the items that passed the test.
https://github.com/dequelabs/axe-core/blob/master/doc/API.md#section-4-performance
In vue-axe, we only use violations results among all results. The
resultTypeshould be set to["violations"]in order to avoid unnecessary calculations.