Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types/toRef): ensure compatibility for ShallowRef unions in TS <=5.3 #12996

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jh-leong
Copy link
Member

@jh-leong jh-leong commented Mar 5, 2025

close #12986

This change may slightly reduce type readability:

declare const v: ShallowRef<number> | number
const _ = toRef(v)
// Before: Ref<number, number> | ShallowRef<number>
// After:  Ref<number, number> | SafeShallowRef<ShallowRef<number>>

Copy link

github-actions bot commented Mar 5, 2025

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38.1 kB 34.3 kB
vue.global.prod.js 158 kB 58 kB 51.6 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.5 kB 18.2 kB 16.7 kB
createApp 54.6 kB 21.3 kB 19.4 kB
createSSRApp 58.8 kB 23 kB 21 kB
defineCustomElement 59.4 kB 22.9 kB 20.8 kB
overall 68.6 kB 26.4 kB 24.1 kB

@jh-leong
Copy link
Member Author

jh-leong commented Mar 5, 2025

/ecosystem-ci run

Copy link

pkg-pr-new bot commented Mar 5, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12996

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12996

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12996

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12996

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12996

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12996

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12996

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12996

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12996

vue

npm i https://pkg.pr.new/vue@12996

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12996

commit: 122f05a

@vue-bot
Copy link
Contributor

vue-bot commented Mar 5, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
primevue success success
language-tools success success
quasar success success
vue-macros success success
radix-vue success success
test-utils success success
router success success
nuxt success success
pinia success success
vant success success
vueuse success success
vite-plugin-vue success success
vue-i18n success success
vitepress success success
vue-simple-compiler success success
vuetify success success

@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toRef<MaybeRef> - can't assign to value in TS
3 participants