Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vapor): defineVaporAsyncComponent #13059

Open
wants to merge 9 commits into
base: vapor
Choose a base branch
from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Mar 18, 2025

  • Added defineVaporAsyncComponent API
  • Extracted shared logic from apiAsyncComponent.ts by creating createAsyncComponentContext and useAsyncComponentState utility functions, shared between core and vapor
  • Added support for template ref forwarding
  • Ported all test cases from apiAsyncComponent.spec.ts except Suspense and KeepAlive related ones

Copy link

netlify bot commented Mar 18, 2025

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 307f757
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/67da324913332e0008d25c98
😎 Deploy Preview https://deploy-preview-13059--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Mar 18, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13059

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13059

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13059

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13059

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13059

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13059

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13059

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13059

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13059

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13059

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13059

vue

npm i https://pkg.pr.new/vue@13059

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13059

commit: 307f757

@edison1105 edison1105 force-pushed the edison/feat/vaporAsyncComponent branch from e629893 to 8d77c1f Compare March 18, 2025 03:18
@edison1105 edison1105 added the scope: vapor related to vapor mode label Mar 18, 2025
@edison1105 edison1105 force-pushed the edison/feat/vaporAsyncComponent branch from ae3b980 to 307f757 Compare March 19, 2025 02:56
@edison1105 edison1105 marked this pull request as ready for review March 19, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: vapor related to vapor mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant