Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle nullish dynamic event name with event modifiers #13060

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

linzhe141
Copy link
Contributor

close #13056

@linzhe141 linzhe141 marked this pull request as draft March 18, 2025 03:28
Copy link

github-actions bot commented Mar 18, 2025

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+73 B) 38.1 kB (+24 B) 34.4 kB (+42 B)
vue.global.prod.js 159 kB (+140 B) 58 kB (+44 B) 51.6 kB (+50 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.5 kB 18.2 kB 16.7 kB
createApp 54.5 kB 21.3 kB 19.5 kB
createSSRApp 58.7 kB 23 kB 21 kB
defineCustomElement 59.4 kB 22.9 kB 20.8 kB
overall 68.6 kB 26.4 kB 24 kB

Copy link

pkg-pr-new bot commented Mar 18, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13060

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13060

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13060

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13060

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13060

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13060

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13060

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13060

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13060

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13060

vue

npm i https://pkg.pr.new/vue@13060

commit: d2d2e3d

@linzhe141 linzhe141 changed the title fix: handle nullish dynamic event name with a modifier fix: handle nullish dynamic event name with event modifiers Mar 18, 2025
@linzhe141 linzhe141 marked this pull request as ready for review March 18, 2025 06:17
@jh-leong
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Mar 18, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
quasar success success
language-tools success success
primevue success success
pinia success success
radix-vue success success
router success success
nuxt failure success
vant success success
vite-plugin-vue success success
vuetify success success
vueuse success success
vitepress success success
vue-macros success success
vue-i18n success success
vue-simple-compiler success success
test-utils success success

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nullish dynamic event name with a modifier creates attribute with modifier's name
4 participants