Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use modelValueModifiers instead of modelModifiers #13070

Open
wants to merge 2 commits into
base: vapor
Choose a base branch
from

Conversation

zhiyuanzmj
Copy link
Member

@zhiyuanzmj zhiyuanzmj commented Mar 19, 2025

When defineModel() and defineModel('model') co-usage, will got duplicated modifiers.
This is also effect Volar to infer modifiers type, so modelModifiers should be change to modelValueModifiers

REPL

image image

Copy link

pkg-pr-new bot commented Mar 19, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13070

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13070

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13070

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13070

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13070

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13070

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13070

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13070

vue

npm i https://pkg.pr.new/vue@13070

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13070

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13070

commit: 85a90cc

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (-53 B) 38.1 kB (-18 B) 34.3 kB (-11 B)
vue.global.prod.js 158 kB (-48 B) 58 kB (-14 B) 51.6 kB (+6 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.5 kB (-53 B) 18.2 kB (-19 B) 16.7 kB (-24 B)
createApp 54.5 kB (-53 B) 21.3 kB (-17 B) 19.4 kB (-48 B)
createSSRApp 58.7 kB (-53 B) 23 kB (-21 B) 20.9 kB (-24 B)
defineCustomElement 59.3 kB (-53 B) 22.9 kB (-19 B) 20.8 kB (-29 B)
overall 68.6 kB (-53 B) 26.4 kB (-19 B) 24.1 kB (+29 B)

@edison1105 edison1105 added scope: vapor related to vapor mode ready to merge The PR is ready to be merged. 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. and removed scope: vapor related to vapor mode labels Mar 19, 2025
@zhiyuanzmj zhiyuanzmj changed the base branch from main to vapor March 20, 2025 02:36
@zhiyuanzmj zhiyuanzmj added the scope: vapor related to vapor mode label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: vapor related to vapor mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants