Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): use linked list to queuing effects #13078

Open
wants to merge 3 commits into
base: minor
Choose a base branch
from

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Mar 20, 2025

Originally reported at stackblitz/alien-signals#48

Reusing nextDep to queued effects is unreliable if the effect changes dependencies in a side effect.

Copy link

github-actions bot commented Mar 20, 2025

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (-106 B) 38.3 kB (-29 B) 34.5 kB (-42 B)
vue.global.prod.js 159 kB (-106 B) 58.2 kB (-30 B) 51.8 kB (-48 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB (-106 B) 18.4 kB (-22 B) 16.8 kB (-27 B)
createApp 55.3 kB (-106 B) 21.5 kB (-22 B) 19.6 kB (-23 B)
createSSRApp 59.5 kB (-106 B) 23.2 kB (-35 B) 21.2 kB (-15 B)
defineCustomElement 60.2 kB (-106 B) 23.1 kB (-26 B) 21 kB (-19 B)
overall 69.5 kB (-102 B) 26.7 kB (-25 B) 24.2 kB (-25 B)

Copy link

pkg-pr-new bot commented Mar 20, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13078

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13078

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13078

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13078

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13078

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13078

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13078

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13078

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13078

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13078

vue

npm i https://pkg.pr.new/vue@13078

commit: ed936af

@johnsoncodehk johnsoncodehk marked this pull request as draft March 21, 2025 02:06
@johnsoncodehk johnsoncodehk marked this pull request as ready for review March 21, 2025 03:31
@johnsoncodehk johnsoncodehk changed the title fix(reactivity): dont using a chain table to queuing effects fix(reactivity): use linked list to queuing effects Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants