fix(types): more precise types for Events and added missing definitions #9675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtorromeo
added a commit
to mtorromeo/vue-patternfly
that referenced
this pull request
Nov 25, 2023
nazarii828
added a commit
to nazarii828/vue-patternfly
that referenced
this pull request
Mar 18, 2024
brendon726
added a commit
to brendon726/Vue-patternfly
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes some imprecise Event definitions and adds some that were missing.
The list was compiled by consulting the list of events documented on MDN that are fired by
Elementor a subclass and where the event is not experimental.Personally, I was impacted more often by the wrong
onInputandonSubmitdefinitions.Some other notable changes are the
onClickevent being changed toPointerEvent(which extendsMouseEvent, so I don't see an issue here) andonScroll, being the only downgrade, which was not documented as anUiEventon MDN, and I am not sure why it was defined as such here.