🐛Fix: v-bind order in vue/attribute-order rule
#421
Merged
+55
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsnik
suggested changes
Mar 21, 2018
docs/rules/attributes-order.md
Outdated
| - OTHER_ATTR | ||
| ex: 'customProp="foo"' | ||
| ex: 'custom-prop="foo"', 'v-bind:prop="foo"', ':prop="foo"', 'v-custom-directive' |
There was a problem hiding this comment.
I don't think we should mix other attributes with bindings.
Let's keep both groups: TWO_WAY_BINDINGS and BINDINGS
There was a problem hiding this comment.
It's a common situation that when user needs to change a static property value to a dynamic binding value. If we separate them into two groups, the user may have to modify the order of these properties and feel confused. Maybe it's still better to let user themselves to sort these attributes.
|
Only solved the conflict but did not change anything else |
chrisvfritz
approved these changes
Mar 22, 2018
chrisvfritz
reviewed
Mar 22, 2018
docs/rules/attributes-order.md
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| ## :book: Rule Details | |||
|
|
|||
| This rule aims to enforce ordering of component attributes. The default order is specified in the [Vue styleguide](https://vuejs.org/v2/style-guide/#Element-attribute-order-recommended) and is: | |||
| This rule aims to enfore ordering of component attributes. The default order is specified in the [Vue styleguide](https://vuejs.org/v2/style-guide/#Element-attribute-order-recommended) and is: | |||
There was a problem hiding this comment.
Looks like a typo here.
michalsnik
changed the title
vue/attribute-order rulevue/attribute-order rule
michalsnik
approved these changes
Jul 11, 2018
This was referenced Jul 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #410 , close #422