Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Chore) Update configs #533

Merged
merged 2 commits into from
Jul 25, 2018
Merged

(Chore) Update configs #533

merged 2 commits into from
Jul 25, 2018

Conversation

michalsnik
Copy link
Member

@michalsnik michalsnik commented Jul 24, 2018 •
edited
Loading

@michalsnik michalsnik added this to the v5.0.0 milestone Jul 24, 2018
@michalsnik michalsnik self-assigned this Jul 24, 2018
@michalsnik michalsnik requested a review from chrisvfritz July 24, 2018 22:31
@michalsnik michalsnik requested a review from mysticatea July 24, 2018 22:55
mysticatea
mysticatea approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@michalsnik michalsnik merged commit d5da866 into master Jul 25, 2018
@michalsnik michalsnik deleted the update-configs branch July 25, 2018 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

@chrisvfritz chrisvfritz Awaiting requested review from chrisvfritz

Assignees

@michalsnik michalsnik

Labels
semver-major
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.

Configurations in upper folders are always ignored
2 participants
@michalsnik @mysticatea