Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(implements #414) Add "no-unused-components" rule #545

Merged
merged 3 commits into from
Aug 13, 2018

Conversation

michalsnik
Copy link
Member

This PR implements rule proposed in #414

@michalsnik michalsnik requested a review from ota-meshi August 11, 2018 23:51
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@michalsnik michalsnik merged commit 8673fc3 into master Aug 13, 2018
@michalsnik michalsnik deleted the add-no-unused-components-rule branch August 13, 2018 21:35
@micbra
Copy link

micbra commented Aug 14, 2018

Great work! :)
When can I expect to be able to use this rule? I'm using 5.0.0-beta.2 and it doesn't include the no-unused-components.js file

@michalsnik
Copy link
Member Author

I'll release it later today @micbra :)

@AnonymousArthur
Copy link

AnonymousArthur commented Aug 15, 2018

What about syntax like:
<template><component is="component_name"/></template>
when

const component_1 = import('./component_1.vue')
export default {
  components: {
    'component_name': component_1
  }
}

this is primarily used for dynamic components.
This currently can not be identified as used component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants