Fix: if no trailing comma, not to leave trailing comma after fixed of order-in-components
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `order-in-components`
michalsnik
reviewed
Sep 13, 2018
lib/rules/order-in-components.js
Outdated
| // If we can upgrade requirements to `eslint@>4.1.0`, this code can be replaced by: | ||
| // return [ | ||
| // fixer.removeRange([codeStart, codeEnd]), | ||
| // fixer.removeRange([removeStart, codeEnd]), |
There was a problem hiding this comment.
We already updated to ESLint >=5 so we can use the above shorthand ☝️
|
@michalsnik Thank you for review! |
michalsnik
approved these changes
Sep 18, 2018
|
Good job @ota-meshi 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #566
This pull request, if there is no trailing comma, make sure
vue/order-in-componentsdoes not leave trailing comma after autofix.Until now, after moving the target property up, we did not delete the last comma of the previous property. because of this, if the target property is the last property, the trailing comma will always remain.
With this fix, autofix will no conflict with
"comma-dangle": ["error", "always"].