Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule use-v-on-exact #271 #602

Merged
merged 3 commits into from
Oct 20, 2018
Merged

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Oct 11, 2018

Implementation of rule use-v-on-exact from #271

@armano2 armano2 force-pushed the 271-use-v-on-exact branch from ebc2af7 to 6ee0fe0 Compare October 11, 2018 03:51
@armano2 armano2 changed the title #271 use-v-on-exact Add rule use-v-on-exact #271 Oct 14, 2018
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

Mostly LGTM.
I have just a comment.

meta: {
docs: {
description: 'enforce usage of `exact` modifier on `v-on`',
category: 'essential',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you set the category undefined?
I'd like to separate PRs to update config presets.

@armano2 armano2 force-pushed the 271-use-v-on-exact branch from 8adbdfe to b830dee Compare October 20, 2018 15:25
@armano2
Copy link
Contributor Author

armano2 commented Oct 20, 2018

@mysticatea category updated and merge conflicts resolved

Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mysticatea mysticatea merged commit 7c574f4 into vuejs:master Oct 20, 2018
@armano2 armano2 deleted the 271-use-v-on-exact branch October 20, 2018 15:34
@armano2 armano2 restored the 271-use-v-on-exact branch October 27, 2018 18:29
@armano2 armano2 deleted the 271-use-v-on-exact branch October 27, 2018 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants