#564 #575 Fix issues with Typescript #613
Merged
+279
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
changed the title
vue/require-default-propvue/require-default-prop
armano2
changed the title
vue/require-default-prop
armano2
force-pushed
the
564-require-default-prop
branch
2 times, most recently
from
d99ac16 to
03ddd6f
Compare
|
i know that this is not solving all issues, but i think its good start |
armano2
force-pushed
the
564-require-default-prop
branch
from
4765dcd to
3f3f944
Compare
armano2
force-pushed
the
564-require-default-prop
branch
from
3f3f944 to
7bc13e0
Compare
|
merge conflict resolved |
|
@michalsnik do you think thats enough for first phase? i started changing rules to support https://github.com/vuejs/vue-class-component, but i will preffer to merge this first |
michalsnik
approved these changes
Nov 6, 2018
There was a problem hiding this comment.
Looks good 👍 Thank you @armano2 ! Although with class support I'd wait a bit until the component API for Vue@3 is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add typescript specific changes:
vue/require-default-propvue/require-prop-typesvue/require-prop-type-constructorvue/require-valid-default-propexport default (Vue as VueConstructor<Vue>).extend({syntaxFix issues: #564 #575