Fix #614 - Improve errors in valid-v-on, detect forbidden keywords #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
suggested changes
Nov 11, 2018
lib/rules/valid-v-on.js
Outdated
| context.report({ | ||
| node, | ||
| loc: node.loc, | ||
| message: "'v-on' directives require a value or verb modifiers (like 'stop' or 'prevent')." |
There was a problem hiding this comment.
we should not use plural word here, besides of that it looks fine 👍
Suggested change
| message: "'v-on' directives require a value or verb modifiers (like 'stop' or 'prevent')." | |
| message: "'v-on' directives require a value or verb modifier (like 'stop' or 'prevent')." |
|
@armano2 updated :) |
armano2
approved these changes
Nov 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves error message pointed in #614. By default if there is no value or one of the two verb modifiers we throw an error, but if someone attempts to use forbidden JS keyword the parser stripes it from AST and we throw the wrong message. Now I'm making sure that the value is really empty, both in the AST and in the code itself, otherwise the rule will throw a message about forbidden value.