Fix #616 - update max attrs per line error message, remove white spaces #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
reviewed
Nov 11, 2018
|
|
||
| if (utils.isBindingAttribute(prop)) { | ||
| propType = 'Binding' | ||
| propName = prop.key.raw.argument |
There was a problem hiding this comment.
argument can be null when v-bind="$props" and error message is:
Binding "null" should be on a new line.
Suggested change
| propName = prop.key.raw.argument | |
| propName = prop.key.raw.argument || 'object as props' |
see. https://vuejs.org/v2/guide/components-props.html#Passing-the-Properties-of-an-Object
There was a problem hiding this comment.
Good catch! I forgot about this case. I think it should actually report Directive "bind" should be on a new line
armano2
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #616
[x] Replaces white spaces with new line instead of just adding new line
[x] Improves
bindingerror message[x] Improves
eventerror message[x] Improves
directiveerror message