Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: make strict for flatten ternary expr (fixes #625) #675

Merged
merged 1 commit into from
Nov 23, 2018
Merged

Fix: make strict for flatten ternary expr (fixes #625) #675

merged 1 commit into from
Nov 23, 2018

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented Nov 23, 2018 •
edited
Loading

This PR fixes #625.

The logic to implement indentation like Conditional Types (a.k.a., flatten ternary expressions) did false positive.
I made stricter it.

michalsnik
michalsnik approved these changes Nov 23, 2018
View reviewed changes
Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@michalsnik michalsnik merged commit 0e51839 into master Nov 23, 2018
@michalsnik michalsnik deleted the issue625 branch November 23, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsnik michalsnik michalsnik approved these changes

Assignees
No one assigned
Labels
bug indent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

script-indent does not work properly with the ternary operator
2 participants
@mysticatea @michalsnik