Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update vue-eslint-parser to v4 #692

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Chore: update vue-eslint-parser to v4 #692

merged 1 commit into from
Dec 3, 2018

Conversation

mysticatea
Copy link
Member

This PR updates vue-eslint-parser to v4.

I have published [email protected] and it changed the AST about Vue.js Filters syntax. Before, the syntax is expressed by BinaryExpression because | is so in JavaScript. Now, the syntax is expressed by a special node VFilterSequenceExpression.

interface VFilterSequenceExpression <: Expression {
    type: "VFilterSequenceExpression"
    expression: Expression
    filters: [ VFilter ]
}

interface VFilter <: Node {
    type: "VFilter"
    callee: Identifier
    arguments: [ Expression ]
}

This update fixes some bugs:

Also, this PR updates vue/html-indent rule to support the new nodes.

This update fixes some bugs:

- fixes #687
- fixes no-unused-vars that filter names don't use varaibles

And add the new node support to indent rules.
@mysticatea mysticatea added the bug label Dec 1, 2018
Copy link
Contributor

@armano2 armano2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its looks nice, but there is one issue with rule this-in-template
it reports errors for filters.

i'm unsure if this is intended but filters are available in references field in VExpressionContainer

Copy link
Contributor

@armano2 armano2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh nvm it was broken before this to

Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

@michalsnik michalsnik merged commit f00e872 into master Dec 3, 2018
@michalsnik michalsnik deleted the issue687 branch December 3, 2018 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing error on Vue template filter with colon (luxon:locale)
3 participants