Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass compilerOptions to compileTemplate when enable inline, fix #1838 #1841

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

Chen-jj
Copy link
Contributor

@Chen-jj Chen-jj commented Jun 17, 2021

What problem does this PR solve?

when using <script setup>:

vue-loader: resolveScript -> compiler-sfc: compileScript -> compiler-sfc: compileTemplate.

compileTemplate should receive and merge options.templateOptions.compilerOptions which resolveScript had not pass in templateOptions.

What had this PR do?

pass templateOptions.compilerOptions to compileScript in resolveScript.fix #1838 .

@transtone
Copy link

Is there any question to merge this PR?

Taro vue3 need this to compile script setup. Please merge it, or reject it and give a suggest.

@b2nil
Copy link

b2nil commented Jul 1, 2021

@sodatea
Hi Haoqun, is vue-loader@v16 now a low priority? Haven't seen any commit or merge recently.

@haoqunjiang haoqunjiang merged commit 1528985 into vuejs:next Jul 6, 2021
haoqunjiang added a commit that referenced this pull request Jul 6, 2021
@haoqunjiang
Copy link
Member

Oops. The fix has already been included in v16.3.0.
I have to revert this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants