Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics with msg size histogram #1697

Merged
merged 2 commits into from
Apr 20, 2023
Merged

feat: add metrics with msg size histogram #1697

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd65117
feat: add metrics with msg size histogram
alrevuelta Apr 20, 2023
e27702c
Add Inf bucket
alrevuelta Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion waku/v2/node/waku_node.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,11 @@ when defined(rln):
import
../waku_rln_relay

declarePublicGauge waku_version, "Waku version info (in git describe format)", ["version"]
declarePublicCounter waku_node_messages, "number of messages received", ["type"]
declarePublicHistogram waku_histogram_message_size, "message size histogram in kB",
buckets = [0.0, 5.0, 15.0, 50.0, 100.0, 300.0, 700.0, 1000.0, Inf]

declarePublicGauge waku_version, "Waku version info (in git describe format)", ["version"]
declarePublicGauge waku_node_errors, "number of wakunode errors", ["type"]
declarePublicGauge waku_lightpush_peers, "number of lightpush peers"
declarePublicGauge waku_filter_peers, "number of filter peers"
Expand Down Expand Up @@ -240,7 +243,10 @@ proc registerRelayDefaultHandler(node: WakuNode, topic: PubsubTopic) =
hash=topic.digest(msg).to0xHex(),
receivedTime=getNowInNanosecondTime()

let msgSizeKB = msg.payload.len/1000

waku_node_messages.inc(labelValues = ["relay"])
waku_histogram_message_size.observe(msgSizeKB)

proc filterHandler(topic: PubsubTopic, msg: WakuMessage) {.async, gcsafe.} =
if node.wakuFilter.isNil():
Expand Down