Change default value of useExpandedHeader to false (#247)

Author: yenienserrano

.github/workflows/cypress_workflow.yml

@@ -30,7 +30,7 @@ env:
   TEST_REPO: ${{ inputs.test_repo != '' && inputs.test_repo || 'opensearch-project/opensearch-dashboards-functional-test' }}
   TEST_BRANCH: "${{ inputs.test_branch != '' && inputs.test_branch || github.base_ref }}"
   FTR_PATH: 'ftr'
-  START_CMD: 'node ../scripts/opensearch_dashboards --dev --no-base-path --no-watch --savedObjects.maxImportPayloadBytes=10485760 --server.maxPayloadBytes=1759977 --logging.json=false --data.search.aggs.shardDelay.enabled=true'
+  START_CMD: 'node ../scripts/opensearch_dashboards --dev --no-base-path --no-watch --savedObjects.maxImportPayloadBytes=10485760 --server.maxPayloadBytes=1759977 --logging.json=false --data.search.aggs.shardDelay.enabled=true --opensearchDashboards.branding.useExpandedHeader=true'
   OPENSEARCH_SNAPSHOT_CMD: 'node ../scripts/opensearch snapshot -E cluster.routing.allocation.disk.threshold_enabled=false'
   CYPRESS_BROWSER: 'chromium'
   CYPRESS_VISBUILDER_ENABLED: true

CHANGELOG.md

@@ -10,6 +10,3 @@ server.ssl.key: "/etc/wazuh-dashboard/certs/dashboard-key.pem"
 server.ssl.certificate: "/etc/wazuh-dashboard/certs/dashboard.pem"
 opensearch.ssl.certificateAuthorities: ["/etc/wazuh-dashboard/certs/root-ca.pem"]
 uiSettings.overrides.defaultRoute: /app/wz-home
-
-opensearchDashboards.branding:
-  useExpandedHeader: false

config/opensearch_dashboards.prod.yml

@@ -1,8 +1,5 @@
 server.host: "0.0.0.0"
 
-opensearchDashboards.branding:
-  useExpandedHeader: false
-
 opensearch.hosts: ["https://indexer:9200"]
 opensearch.ssl.verificationMode: none
 opensearch.username: "kibanaserver"

docker/config/opensearch_dashboards.dev.security.yml

@@ -1,4 +1 @@
 server.host: "0.0.0.0"
-
-opensearchDashboards.branding:
-  useExpandedHeader: false

docker/config/opensearch_dashboards.dev.yml

@@ -101,9 +101,15 @@ it('builds a generated plugin into a viable archive', async () => {
      info running @osd/optimizer
      │ info initialized, 0 bundles cached
      │ info starting worker [1 bundle]
+     │ warn worker stderr Browserslist: caniuse-lite is outdated. Please run:
+     │ warn worker stderr   npx update-browserslist-db@latest
+     │ warn worker stderr   Why you should do it regularly: https://github.com/browserslist/update-db#readme
      │ succ 1 bundles compiled successfully after <time>
      info copying assets from \`public/assets\` to build
      info copying server source into the build and converting with babel
+    Browserslist: caniuse-lite is outdated. Please run:
+      npx update-browserslist-db@latest
+      Why you should do it regularly: https://github.com/browserslist/update-db#readme
      info running yarn to install dependencies
      info compressing plugin into [fooTestPlugin-1.0.0.zip]
      info cleaning up compression temporary artifacts"
@@ -189,9 +195,15 @@ it('builds a non-semver generated plugin into a viable archive', async () => {
      info running @osd/optimizer
      │ info initialized, 0 bundles cached
      │ info starting worker [1 bundle]
+     │ warn worker stderr Browserslist: caniuse-lite is outdated. Please run:
+     │ warn worker stderr   npx update-browserslist-db@latest
+     │ warn worker stderr   Why you should do it regularly: https://github.com/browserslist/update-db#readme
      │ succ 1 bundles compiled successfully after <time>
      info copying assets from \`public/assets\` to build
      info copying server source into the build and converting with babel
+    Browserslist: caniuse-lite is outdated. Please run:
+      npx update-browserslist-db@latest
+      Why you should do it regularly: https://github.com/browserslist/update-db#readme
      info running yarn to install dependencies
      info compressing plugin into [fooTestPlugin-1.0.0.x.zip]
      info cleaning up compression temporary artifacts"

packages/osd-plugin-helpers/src/integration_tests/build.test.ts

@@ -83,7 +83,7 @@ export const config = {
         defaultValue: 'Wazuh',
       }),
       useExpandedHeader: schema.boolean({
-        defaultValue: true,
+        defaultValue: false,
       }),
     }),
     survey: schema.object({

src/core/server/opensearch_dashboards_config.ts

@@ -246,7 +246,7 @@ export default () =>
         }),
         faviconUrl: Joi.any().default('/'),
         applicationTitle: Joi.any().default(''),
-        useExpandedHeader: Joi.boolean().default(true),
+        useExpandedHeader: Joi.boolean().default(false),
       }),
       survey: Joi.object({
         url: Joi.any().default('/'),

src/core/server/rendering/__snapshots__/rendering_service.test.ts.snap

@@ -79,6 +79,7 @@ export default function () {
         `--opensearchDashboards.branding.mark.defaultUrl=https://opensearch.org/assets/brand/SVG/Mark/opensearch_mark_default.svg`,
         `--opensearchDashboards.branding.mark.darkModeUrl=https://opensearch.org/assets/brand/SVG/Mark/opensearch_mark_darkmode.svg`,
         `--opensearchDashboards.branding.applicationTitle=OpenSearch`,
+        `--opensearchDashboards.branding.useExpandedHeader=true`,
       ],
     },
     services,