Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value of useExpandedHeader to false #247

Merged
merged 8 commits into from
Jul 25, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jul 17, 2024

Description

The default value of the useExpandedHeader is changed to false so that the default black bar is hidden and to display it you have to use the setting

Issues Resolved

Test

  1. Remove the useExpandedHeader setting from opensearch_dashboard.yml file
  2. See that the black header bar does not appear.
  3. Add the useExpandedHeader setting with the value true
  4. See that the black header bar appear.
opensearchDashboards.branding:
  useExpandedHeader: true

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Jul 17, 2024
@yenienserrano yenienserrano linked an issue Jul 18, 2024 that may be closed by this pull request
@Desvelao
Copy link
Member

Due to the value by default changed from true to false to not display the expander header, we could the explicit setting on the configuration file of Wazuh dashboard.

@Desvelao
Copy link
Member

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
By default, the expanded header should not appear 🟢
Add the setting to enable the expanded header should display it 🟢

Details

🟢 By default, the expanded header should not appear

Chrome - 🟢
image
Firefox - ⚫

Safari - ⚫

🟢 Add the setting to enable the expanded header should display it

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

Desvelao
Desvelao previously approved these changes Jul 22, 2024
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucianogorza lucianogorza requested review from lucianogorza and removed request for lucianogorza July 24, 2024 16:06
@Desvelao Desvelao self-requested a review July 25, 2024 10:54
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desvelao Desvelao merged commit d6da85a into 4.9.0 Jul 25, 2024
63 checks passed
@Desvelao Desvelao deleted the bug/241-the-black-line-in-the-header-appears branch July 25, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The black line in the header appears
2 participants