Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added NodeJS options in the node exec command #471

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Added NodeJS options in the node exec command #471

merged 1 commit into from
Dec 30, 2024

Conversation

JuanGarriuz
Copy link

@JuanGarriuz JuanGarriuz commented Dec 27, 2024 •
edited by asteriscos
Loading

Description

Added ${NODE_OPTIONS} to use_node

Issues Resolved

Evidences

Sin título
Sin título2

Test

  • Setup the environment and test that this command don't stop the dashboard.service
  • Force an unhandled promise exception

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz self-assigned this Dec 27, 2024
@JuanGarriuz JuanGarriuz linked an issue Dec 27, 2024 that may be closed by this pull request
Include node options in node exec #468
Closed
Tostti
Tostti approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢
imagen
imagen

CR 🟢

LGTM

yenienserrano
yenienserrano approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test: 🟢 arm

image

image

@Tostti Tostti merged commit d517210 into 4.10.0 Dec 30, 2024
87 of 88 checks passed
@Tostti Tostti deleted the fix/468-added-nodejs-option-in-node-exec-command branch December 30, 2024 17:07
@Desvelao Desvelao mentioned this pull request Jan 8, 2025
Closed
4 tasks
@asteriscos asteriscos mentioned this pull request Jan 9, 2025
Closed
1 task
@Tostti Tostti mentioned this pull request Jan 16, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tostti Tostti Tostti approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@JuanGarriuz JuanGarriuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include node options in node exec
3 participants
@JuanGarriuz @Tostti @yenienserrano