Changed capitalized words to lowercase + some typos #9
Conversation
doc/specs/stdlib_hash_procedures.md
Outdated
| intrinsic `RANDOM_INIT`. | ||
|
|
||
| `odd_random_integer` is intended to generate seeds for | ||
| `universal_mult_hash`. `ODD_random_number` uses Fortran's intrinsic |
There was a problem hiding this comment.
@wclodius2 I couldn't find ODD_RANDOM_NUMBER in the source code. Should it be:
| `universal_mult_hash`. `ODD_random_number` uses Fortran's intrinsic | |
| `universal_mult_hash`. `odd_random_integer` uses Fortran's intrinsic |
There was a problem hiding this comment.
Its discussion is a leftover from earlier versions of the code. Some no longer included algorithms required an odd random seed. Either you or I can eliminate the discussion of that procedure.
There was a problem hiding this comment.
Should it be eliminate from the code too? (probably better I do it before merging, to avoid conflicts)
There was a problem hiding this comment.
As I remember, this is needed for universal_mult_hash, which is still provided. So, I think it could remain on the code, right?
There was a problem hiding this comment.
Sorry, I was wrong. I did a grep on odd_random_number for the source code, and didn't find anything, when, of course, I should have done a grep on odd_random_integer, which finds multiple references in the code. In the documentation the references to odd_random_number should have been changed to odd_random_integer and otherwise retained. I can add them back in if necessary after the merge.
There was a problem hiding this comment.
@wclodius2 I changed odd_random_integer to odd_random_number and kept the text there. After resolving a conflict, it should be fine now.
There was a problem hiding this comment.
Odd, I had suggested changing odd_random_nuber to odd_random_integer, while you claim to have done the reverse. FWIW I have no problems with that if you also changed it in the source code.
There was a problem hiding this comment.
I am sorry. I meant "I changed odd_random_number to `odd_random_integer", as you proposed.
Again sorry for the confusion.
|
Do you think you are ready to be merged? |
Yes, it can be merged. |
Based on the reviews, I already changes most of the capitalized words to lowercase words.
I also corrected a few typos, I still discovered.
Note: Capitalized words were not a problem for me... but I guess it is to be uniform across the whole specs.