Correct missing checkFatal function #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Apr 9, 2017
Adding weaveworks/mesh#70 Not updating the submodule, because then we would break pulling for a lot of people.
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Apr 9, 2017
Adding weaveworks/mesh#70 Not updating the submodule, because then we would break pulling for a lot of people.
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Apr 9, 2017
Adding weaveworks/mesh#70 Not updating the submodule, because then we would break pulling for a lot of people.
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Apr 10, 2017
Adding weaveworks/mesh#70 Not updating the submodule, because then we would break pulling for a lot of people.
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Apr 10, 2017
Adding weaveworks/mesh#70 Not updating the submodule, because then we would break pulling for a lot of people.
|
@bboreham mind taking a look at this? |
bboreham
reviewed
Apr 11, 2017
peer_name_hash.go
Outdated
| res, err := hex.DecodeString(string(name)) | ||
| checkFatal(err) | ||
| if err != nil { | ||
| panic(fmt.Sprintf("unable to decode name to bytes: %q", string(name))) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Apr 12, 2017
Adding weaveworks/mesh#70 Not updating the submodule, because then we would break pulling for a lot of people.
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Apr 12, 2017
Adding weaveworks/mesh#70 Not updating the submodule, because then we would break pulling for a lot of people.
For the case when using peer_name_hash, the checkFatal function is not defined; replace with a panic.
justinsb
force-pushed
the
fix_checkfatal
branch
from
0ba8286 to
75f5738
Compare
|
Thanks! |
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Apr 19, 2017
Adding weaveworks/mesh#70 Not updating the submodule, because then we would break pulling for a lot of people.
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Apr 20, 2017
Adding weaveworks/mesh#70 Not updating the submodule, because then we would break pulling for a lot of people.
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Apr 23, 2017
Adding weaveworks/mesh#70 Not updating the submodule, because then we would break pulling for a lot of people.
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Apr 25, 2017
Adding weaveworks/mesh#70 Not updating the submodule, because then we would break pulling for a lot of people.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the case when using peer_name_hash, the checkFatal function is not
defined; replace with a panic.