Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot set property _isFinished of #<Object> which has only a getter #160

Closed
zh99998 opened this issue Jul 22, 2017 · 4 comments · Fixed by #165
Closed

Cannot set property _isFinished of #<Object> which has only a getter #160

zh99998 opened this issue Jul 22, 2017 · 4 comments · Fixed by #165

Comments

@zh99998
Copy link

zh99998 commented Jul 22, 2017

I got Cannot set property _isFinished of #<Object> which has only a getter
in https://github.com/web-animations/web-animations-js/blob/master/src/animation.js#L194

seems _isFinished is only a getter but cancel() trying to set value.
@ewilligers
Copy link
Contributor

We'll need more information if we are to reproduce this.
For example, which browser version are you using?

@dstoc
Copy link
Contributor

dstoc commented Jul 25, 2017

It might help, but if you look at the code it seems pretty obviously broken.

@zh99998
Copy link
Author

zh99998 commented Jul 25, 2017

yes it's obviously broken, not browser related, any browser without native Web Animation API could reproduce it

@dstoc
Copy link
Contributor

dstoc commented Jul 25, 2017

@ewilligers this should repro with 'use strict'; enabled. It's probably safe to remove the line setting _isFinished, since it's a no-op otherwise.

ewilligers pushed a commit to ewilligers/web-animations-js that referenced this issue Aug 13, 2017
@ericwilligers
Do not write to readonly _isFinished
e2782af 
The property _isFinished is readonly. cancel() should not attempt to
write to the property.

resolves web-animations#160
@ewilligers ewilligers mentioned this issue Aug 13, 2017
Merged
@simonness simonness mentioned this issue Feb 28, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not write to readonly _isFinished ewilligers/web-animations-js
3 participants
@zh99998 @dstoc @ewilligers