Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display property not overridden by animation in native impl #394

Closed
hgl opened this issue Jul 10, 2015 · 4 comments
Closed

display property not overridden by animation in native impl #394

hgl opened this issue Jul 10, 2015 · 4 comments

Comments

@hgl
Copy link

hgl commented Jul 10, 2015

http://jsbin.com/vekakezuwa/1/edit?html,css,js,output

There is supposed be a teal box displayed, but in chrome, nothing is displayed.

This doesn't relate to the polyfill, but I guess you guys also write the native impl? Guess I will just report it here. Let me know if I should move this to crbugs.

@hgl hgl changed the title display property not override by animation in native impl display property not overridden by animation in native impl Jul 10, 2015
@Martin-Pitt
Copy link

Display blocks are 'not animatable' in CSS animations either, due to spec.
If the polyfill doesn't do it then this should be working as intended.

I know it sucks, because I think display should be perfectly reasonably animatable when given a step easing/timing function with only two states.

@hgl
Copy link
Author

hgl commented Jul 23, 2015

According to the spec, it should be animatable, I believe this is a chrome bug.

Hope the native impl could catch up soon. In the mean while, I'd like to suggest that the guarding code should test for properties like display, and when browsers can't animate them, let the polyfill kick in.

Thoughts?

@shans
Copy link
Contributor

shans commented Aug 10, 2015

It's not clear that this should be animatable.

Setting display can change running animations (animations are cancelled inside display: none subtrees). This makes display somewhat like the animation-* and transition-* properties, which are not animatable because of the fact that changing them can impact the state of running animations.

@hgl
Copy link
Author

hgl commented Aug 10, 2015

I posted the previous message when we haven't chatted on irc. :)

So have you reached a consensus with Birtles on this topic?

ewilligers pushed a commit to ewilligers/web-animations-next that referenced this issue Jul 26, 2016
Certain properties are not animatable.
For example, properties defining animation parameters are not animatable.
https://w3c.github.io/web-animations/#concept-not-animatable

Web Animations must ignore such properties.

This closes web-animations#394
ewilligers pushed a commit to ewilligers/web-animations-next that referenced this issue Jul 26, 2016
Certain properties are not animatable.
For example, properties defining animation parameters are not animatable.
https://w3c.github.io/web-animations/#concept-not-animatable

Web Animations must ignore such properties.

This closes web-animations#394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants