Animation constructor easing #136
Merged
+58
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 11, 2014
Closed
|
The update to mocha.js is unrelated, I'd prefer it to be in its own change as it's very large. We should probably fix the version of mocha so we don't run into this hassle with the git-status check. |
|
I can do a separate CL for the mocha update, but I don't know how to remove the diff from this CL. |
Need to fix, but might want to do some refactoring at the same time.
| @@ -15,7 +15,8 @@ | |||
| (function(shared, scope, testing) { | |||
|
|
|||
| function groupChildDuration(node) { | |||
| return node.timing.delay + node.activeDuration + node.timing.endDelay; | |||
| var _timing = shared.normalizeTimingInput(node.timing); | |||
There was a problem hiding this comment.
We don't want to be normalizing here if possible as this function gets called multiple times per frame.
There was a problem hiding this comment.
should be OK to use node._timing
so that we don't have to re-normalize when we compute durations.
|
@shans @alancutter ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug #131.
Timing functions weren't working with explicitly constructed Animations because normalizeTimingInput was being called twice.
Now we store the raw timing input in TimedItem.timing, and the normalized timing in TimedItem._timing.
Timing is normalized at creation time for explicitly constructed timed items, and at play time (in scope.AnimationTimeline.prototype._play) for timed items created using Element.animate.
@shans ptal